bpo-46705: Memory optimization for set.issubset #31267
Conversation
Optimized `set.issubset` to use `O(min(len(self), len(set(other))))` memory instead of `O(len(set(other))) memory by using `self.intersection(other)` instead of `set(other)`. https://bugs.python.org/issue46705
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
The idea LGTM, but the implementation contains some errors (it misuses the C boolean as the Python boolean). Closed in favor of #92799. |
Instead of using
set(other)duringset.issubset, useself.intersection(other)to avoid using unnecessary memory.https://bugs.python.org/issue46705