bpo-39355: making Python.h compatible with C++20 compilers #31282
Conversation
There was a problem hiding this comment.
Thank you for your PR!
I would strongly suggest to rename to mod instead of pyModule. It is more aligned with the code style of the majority of the CPython code base.
Also:
- Please write a NEWS entry (I'm thinking something like "Make Python.h compatible with C++20 compilers", but there may be better ways to present this).
- Please add a note in What's New. The text itself can be just a C&P of the NEWS entry.
- Please update the PR title to more accurately reflect the change: you are making Python.h compatible with C++20 compilers.
IMO, we should probably backport this to 3.10 and 3.9. I'm adding the labels; if anyone disagrees, please remove them :)
erlend-aasland
added
needs backport to 3.9
|
BTW, did you test that it is actually possible to use a C++20 compiler for external modules after this change? AFAICS, it should be ok, but assumption has resulted in a lot of strange stuff. |
Renamed module to mod in header files
AliyevH
changed the title
| @@ -0,0 +1 @@ | |||
| Make Python.h compatible with C++20 compilers | |||
There was a problem hiding this comment.
Nitpick:
| Make Python.h compatible with C++20 compilers | |
| Make Python.h compatible with C++20 compilers. |
|
@erlend-aasland Thanks for the corrections ! renamed pyModule to mod. |
|
Thanks for the amendments, Hasan. Could you please also add an entry to What's New. Something like this should suffice (given that this actually is a sufficient change): diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst
index 5738745ba1..4cf489ad5e 100644
--- a/Doc/whatsnew/3.11.rst
+++ b/Doc/whatsnew/3.11.rst
@@ -650,6 +650,9 @@ Build Changes
be removed at some point in the future. (Contributed by Mark Dickinson in
:issue:`45569`.)
+* Python.h is now compatible with C++20 compilers. (Contributed by by Hasan
+ Aliyev in :issue:`39355`.)
+
C API Changes
=============I'll see if I can get around to test it using G++ 11. |
| @@ -0,0 +1 @@ | |||
| Make Python.h compatible with C++20 compilers. | |||
There was a problem hiding this comment.
Would you mind to explain that the change is to avoid the usage of "module" which became a keyword in C++20?
There was a problem hiding this comment.
Yes @vstinner, you are right!
I have mentioned in bugs.python.org, about this change.
After making a little research, i realized that this "module" keyword has meaning with "export"
Sorry i am not c++ expert )) If somebody have knowledge about it, share it plz :)
There was a problem hiding this comment.
I don't understand your comment. Do you mean that https://bugs.python.org/issue39355 is not a bug and the Python C API is compatible with C++20?
If there is an issue, please explain the change in NEWS entry. "Make Python.h compatible with C++20 compilers." is not enough.
There was a problem hiding this comment.
@vstinner I asked question ))
There was a problem hiding this comment.
@vstinner it was interesting for me, if "module" keyword has meaning with "export" how gcc will treat "module" without "export" keyword ?
There was a problem hiding this comment.
So far, I failed to reproduce https://bugs.python.org/issue39355 issue: using the Python C API in C++ doesn't emit any compiler warning or compiler error. See my test: https://bugs.python.org/issue39355#msg416256
There was a problem hiding this comment.
@vstinner thanks for great investigation!
There was a problem hiding this comment.
You're welcome. I'm now considering serious to convert #32175 to a real unit test to make sure that the Python C API is compatible with C++.
There was a problem hiding this comment.
First step: https://bugs.python.org/issue47164
|
This PR solves a non-problem: https://bugs.python.org/issue39355#msg416257 |
https://bugs.python.org/issue39355