-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46933: Make pwd module optional (GH-31700) #31700
Conversation
Hm, for some reason, $ python3.11
Python 3.11.0a5 (v3.11.0a5:c4e4b91557, Feb 3 2022, 14:54:01) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import posixpath
>>> posixpath.expanduser("~erlendaasland")
'/Users/erlendaasland'
>>> ^D
$ ./python.exe
Python 3.11.0a5+ (heads/no-pwd-dirty:a6ca976941, Mar 6 2022, 00:31:10) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import posixpath
>>> posixpath.expanduser("~erlendaasland")
'~erlendaasland'
>>> ^D
$ grep getpwuid config.cache
ac_cv_func_getpwuid=${ac_cv_func_getpwuid=yes}
ac_cv_func_getpwuid_r=${ac_cv_func_getpwuid_r=yes} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use m4_foreach_w
(or m4_map_args_w
) in PY_STDLIB_MOD
and PY_STDLIB_MOD_SIMPLE
when checking py_stdlib_not_available
for unavailable modules. There may be a more elegant solution.
I tried |
Yeah, I tried some experiments with the m4 wrappers yesterday, but they didn't work out. |
We may have to restructure the test. I have a working solution, will clean it up and push it later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this approach works swell. Tested on my mac; all good. I left some comments nits; do with them as you please :)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
https://bugs.python.org/issue46933