-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-91134: Correct docstrings for built-in in-place operators #31802
Conversation
…ors. The whitespace in the example in the string has also been mde PEP-8 compliant.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find out how to test slots so ran full suite:
412 tests OK.
2 tests failed:
test_asyncio test_embed
I think this qualifies as a pass. Anyway this has no side effects.
Closing and reopening to trigger the bots. |
@nickovs: Status check is done, and it's a failure ❌ . |
Please sign the CLA or we can't go forward. |
I already signed the CLA, back on March 11th, but it seems that there is a bug in the CLA-checking bot that means that if you have multiple email addresses on your GitHub account it needs you to sign multiple CLAs, in the same name but listing the different addresses. I've signed a second CLA so hopefully this can proceed. |
Unfortunately the CLA check is still failing. As a workaround, maybe you can re-commit with the email address you signed the CLA with and force-push the branch. |
@nickovs: Status check is done, and it's a failure or timed out ❌. |
OK. The system seems to now be showing the CLA is signed and all checks are passing. |
That's amazing!! Thanks for your help Nicko! @rhettinger / @JelleZijlstra We can get this merged in now :) |
The CLA check is green; merging |
MacOS failure is known and is being fixed on the GitHub side. @iritkatriel could you merge this PR (with its backports) manually please? All other tests successfully pass. |
Thanks @nickovs for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, @nickovs and @iritkatriel, I could not cleanly backport this to |
Sorry @nickovs and @iritkatriel, I had trouble checking out the |
@iritkatriel I backported the PR but the bot failed to link them here: |
Before backporting, could people go to the issue first to discuss the relevance of this change? @rhettinger does not agree that there is a bug to be fixed here and requested to revert. |
This PR was approved by @rhettinger . |
…ython#31802)" This reverts commit 128379b.
PR to revert the change: #102146 Let's close the issue once we've come to a decision on this. |
For ease of reference, the issue is #91134 and the relevant comment is #91134 (comment). |
GH-102041 is a backport of this pull request to the 3.10 branch. |
…ython#31802) (python#102146) Revert "bpo-46978: Correct docstrings for in-place builtin operators (python#31802)" This reverts commit 128379b.
The whitespace in the example code included in the doc string has also been made PEP-8 compliant.
https://bugs.python.org/issue46978
Automerge-Triggered-By: GH:rhettinger