Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 #31891

Merged
merged 3 commits into from
Mar 18, 2022
Merged

bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 #31891

merged 3 commits into from
Mar 18, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 15, 2022 •
edited by miss-islington
Loading

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.

Automerge-Triggered-By: GH:brettcannon

@hugovk hugovk requested a review from a team as a code owner March 15, 2022 07:50
@hugovk hugovk added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 15, 2022
@hugovk

This comment was marked as resolved.

Sign in to view
@hugovk hugovk added the docs Documentation in the Doc dir label Mar 15, 2022
@hugovk hugovk force-pushed the pep594-document-3.12-removals branch from 662a963 to 3eb9ba8 Compare March 15, 2022 10:05
@hugovk hugovk requested review from tiran and brettcannon March 15, 2022 10:49
@brettcannon
Copy link
Member

Two things.

One, can you add a directive to the docs like:

cpython/Doc/library/imp.rst

Line 6 in 099f756

:deprecated:

? That's what makes a module say "deprecated" in the module index.

Two, the SC wanted to leave out target removal versions in the docs in case we have to change something due to feedback (in the code itself via the warnings.warn call still makes sense). But since these modules were already deprecated and the community has not come back asking to save them I think specifying 3.12 is safe.

@hugovk
Copy link
Member Author

hugovk commented Mar 16, 2022

Two things.

One, can you add a directive to the docs like:

cpython/Doc/library/imp.rst

Line 6 in 099f756

:deprecated:

? That's what makes a module say "deprecated" in the module index.

Done!

Also added to the Superseded Modules page listing deprecated modules (imp is there), putting those needing most attention first (to be removed soonest, and most recently added).

Two, the SC wanted to leave out target removal versions in the docs in case we have to change something due to feedback (in the code itself via the warnings.warn call still makes sense). But since these modules were already deprecated and the community has not come back asking to save them I think specifying 3.12 is safe.

👍

@miss-islington miss-islington merged commit 7747384 into python:main Mar 18, 2022
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 77473846439b8a3eae66de1a1cfe931619f38513 3.10

@miss-islington miss-islington self-assigned this Mar 18, 2022
@miss-islington
Copy link
Contributor

Sorry @hugovk, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 77473846439b8a3eae66de1a1cfe931619f38513 3.9

@hugovk hugovk deleted the pep594-document-3.12-removals branch March 19, 2022 20:39
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 19, 2022
@hugovk
[3.10] bpo-47022: Document asynchat, asyncore and smtpd removals in 3…
f5751f7 
….12 (pythonGH-31891)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk mentioned this pull request Mar 19, 2022
Merged
@bedevere-bot
Copy link

GH-31997 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 19, 2022
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 19, 2022
@bedevere-bot
Copy link

GH-31998 is a backport of this pull request to the 3.9 branch.

asvetlov pushed a commit that referenced this pull request Mar 20, 2022
@hugovk
[3.10] bpo-47022: Document asynchat, asyncore and smtpd removals in 3…
94f038c 
….12 (GH-31891) (#31997)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 22, 2022
@hugovk
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
5419793 
…12 (pythonGH-31891)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
brettcannon pushed a commit that referenced this pull request Mar 22, 2022
@hugovk
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
af341eb 
…12 (GH-31891) (#31998)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This was referenced Apr 11, 2022
Closed
Closed
@hugovk hugovk mentioned this pull request Apr 26, 2022
Merged
This was referenced May 9, 2022
Open
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@hugovk @hello-adam
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
bf720a3 
…12 (pythonGH-31891) (python#31998)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@brettcannon brettcannon brettcannon approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugovk @brettcannon @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni