-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-90005: Port _ctypes to PY_STDLIB_MOD #32229
Conversation
07a2d53
to
48b7e12
Compare
libffi was de-vendored in 3.7 (Linux, BSD) and 3.8 (Windows). We only keep a copy for macos around. |
🤖 New build scheduled with the buildbot fleet by @tiran for commit cc5cb24a3c148b044e5bc2cb606b8a612e6f0440 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
ctypes tests are failing on ARM64 macOS |
I have no clue how the SDK stuff works on macOS. In order to land the PR I would need some assistance from @ned-deily or @ronaldoussoren . Or can we drop the SDK and use system-ffi on all system? |
🤖 New build scheduled with the buildbot fleet by @tiran for commit 54e6b1122be7ab28dc0456516cc4d3f81fc0df7e 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
I'll try to look at the PR over the weekend. As a general statement I'd prefer to use the system install of libffi on macOS because Apple includes some magic in its version to ensure libffi closures work properly with their code signature system (in particular some magic to ensure that you don't need the "JIT" entitlement to use closures). |
🤖 New build scheduled with the buildbot fleet by @tiran for commit 53607e36d3dd2446103a5d9175b8d3ee1e271e08 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
🤖 New build scheduled with the buildbot fleet by @tiran for commit e4ab8cf4c4d2bf9156f0551d8df68299ef153295 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@ned-deily @ronaldoussoren I would like to merge this PR rather sooner than later into main. It is required to test ctypes on wasm32-emscripten and will allow us to remove setup.py. Tests are passing on macOS. |
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Status check is done, and it's a success ✅ . |
Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no
https://bugs.python.org/issue45847
Automerge-Triggered-By: GH:tiran