bpo-21983: Fix a crash in ctypes.cast() in case the type argument is a ctypes structured data type. #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Feb 22, 2018
| array = array_type() | ||
| self.assertRaises(TypeError, cast, array, None) | ||
| self.assertRaises(TypeError, cast, array, array_type) | ||
| class Struct(Structure): |
There was a problem hiding this comment.
I don't know if cpython does this, but linking to the bug number in the test might be nice.
eric-wieser
approved these changes
Feb 22, 2018
zooba
approved these changes
May 9, 2018
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2018
…ed data type (pythonGH-3859) (cherry picked from commit d518d8b) Co-authored-by: Oren Milman <orenmn@gmail.com>
|
GH-6745 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @orenmn and @zooba, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2018
…ed data type (pythonGH-3859) (cherry picked from commit d518d8b) Co-authored-by: Oren Milman <orenmn@gmail.com>
|
GH-6746 is a backport of this pull request to the 3.6 branch. |
|
sorry Eric, but i am too busy nowadays... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, add tests to
test_ctypesto make sure thatcast()raises aTypeErrorin case of a bad type argument (and doesn't crash).https://bugs.python.org/issue21983