Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29728: Provide socket.TCP_NOTSENT_LOWAT #477

Merged
merged 5 commits into from
Mar 23, 2017
Merged

Conversation

njsmith
Copy link
Contributor

@njsmith njsmith commented Mar 5, 2017

New TCP option available on recent MacOS and Linux.

@alex
Copy link
Member

alex commented Mar 5, 2017

This should probably be documented in socket.rst

@Mariatta
Copy link
Member

Mariatta commented Mar 5, 2017

Please create a ticket in bugs.python.org to track this :)

@njsmith
Copy link
Contributor Author

njsmith commented Mar 5, 2017

@alex: good point, done.

@Mariatta: https://bugs.python.org/issue29728

@Mariatta Mariatta changed the title Provide socket.TCP_NOTSENT_LOWAT bpo-29728: Provide socket.TCP_NOTSENT_LOWAT Mar 5, 2017
@Mariatta
Copy link
Member

Mariatta commented Mar 7, 2017

@njsmith seems like there's trailing whitespace issue with the docs change 😅

Will you be able to fix it? (see travis output)

@Mariatta
Copy link
Member

Mariatta commented Mar 7, 2017

I think this should be added to Misc/NEWS too.

@njsmith
Copy link
Contributor Author

njsmith commented Mar 18, 2017

@Mariatta: whoops, I somehow missed the notification on your earlier comments. Thanks for fixing things up!

@Mariatta
Copy link
Member

Well... in my attempt to clean this however... I actually messed up your branch 😅 Sorry about this. I will try to clean it up later..

@njsmith
Copy link
Contributor Author

njsmith commented Mar 18, 2017

Rebased and cleaned up

@njsmith
Copy link
Contributor Author

njsmith commented Mar 18, 2017

no idea what that travis failure is about

@Mariatta
Copy link
Member

Thanks @njsmith :)

I think the travis failure is a separate matter, tracked in python/core-workflow#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants