Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31804: Fix multiprocessing.Process with broken standard streams #6079

Merged
merged 1 commit into from
Mar 11, 2018

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Mar 11, 2018

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows). Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by @poxthegreat.

https://bugs.python.org/issue31804

In some conditions the standard streams will be None or closed in the child process
(for example if using "pythonw" instead of "python" on Windows).  Avoid failing
with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat.
@bedevere-bot
Copy link

@pitrou: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pitrou, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e756f66c83786ee82f5f7d45931ae50a6931dd7f 3.6

@miss-islington
Copy link
Contributor

Sorry, @pitrou, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e756f66c83786ee82f5f7d45931ae50a6931dd7f 2.7

@miss-islington
Copy link
Contributor

Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@pitrou pitrou deleted the bpo-31804-mp-std-streams branch March 11, 2018 18:24
@bedevere-bot
Copy link

GH-6080 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2018
…ythonGH-6079)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat.
(cherry picked from commit e756f66)

Co-authored-by: Antoine Pitrou <pitrou@free.fr>
pitrou added a commit to pitrou/cpython that referenced this pull request Mar 11, 2018
…eams (pythonGH-6079)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat..
(cherry picked from commit e756f66)
@bedevere-bot
Copy link

GH-6081 is a backport of this pull request to the 3.6 branch.

pitrou added a commit that referenced this pull request Mar 11, 2018
…H-6079) (GH-6080)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat.
(cherry picked from commit e756f66)

Co-authored-by: Antoine Pitrou <pitrou@free.fr>
pitrou added a commit that referenced this pull request Mar 11, 2018
…eams (GH-6079) (GH-6081)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat..
(cherry picked from commit e756f66)
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
…ython#6079)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants