gh-91621: Fix typing.get_type_hints for collections.abc.Callable #91656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors logic in typing.get_args. The trickiness comes from how we flatten args in collections.abc.Callable, see https://bugs.python.org/issue42195
hauntsaninja
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
|
I think we can skip news since this is just a fix for the unreleased #30900 |
AlexWaygood
added
type-bug
Lib/typing.py
Outdated
| @@ -350,7 +350,11 @@ def _eval_type(t, globalns, localns, recursive_guard=frozenset()): | |||
| ForwardRef(arg) if isinstance(arg, str) else arg | |||
| for arg in t.__args__ | |||
| ) | |||
| t = t.__origin__[args] | |||
| if (t.__origin__ is collections.abc.Callable | |||
There was a problem hiding this comment.
I know this code pattern appears once in Generic code and once here now. Should we just convert this into one function? Maybe _should_flatten_callable_args()? Seems abit tiresome to repeat this (and it's also confusing for people who haven't dealt with Callable's args before).
There was a problem hiding this comment.
(sorry, missed this comment)
I added a helper function for this
JelleZijlstra
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors logic in typing.get_args. The trickiness comes from how we
flatten args in collections.abc.Callable, see
https://bugs.python.org/issue42195
#91621