gh-87452 Making returncode unreliability explicit

[zitterbewegung]

gh-87452: Making returncode unreliability explicit

We make explicit that the value stored in return code is best returned by poll instead of using the value in return code.

[bedevere-bot]

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

[benjaminp]

Thank you for the PR.

I don't think "out-of-date" is the right term here. Either the entire subprocess.Subprocess instance is aware of the exit of the child process and knows the return code, or it doesn't. The first paragraph of the method documentation could perhaps be rearranged to more clearly state the order of events instead of appending another sentence.

[benjaminp]

I would propose:

The child return code. Initially ``None``, :attr:`returncode` is set by :meth:`poll` and :meth:`wait` after process termination is observed.
``

[erlend-aasland]

Please remove the duplicate NEWS entry.

[erlend-aasland]

Again, please remove the duplicate NEWS entry. Also please address Benjamin's remarks.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[slateny]

@zitterbewegung Would you still be interested in giving the PR a quick update per the reviews above?

[zitterbewegung]

Sorry I can do that.

[netlify]

✅ Deploy Preview for python-cpython-preview ready!

Name	Link
🔨 Latest commit	41a5d22
🔍 Latest deploy log	https://app.netlify.com/sites/python-cpython-preview/deploys/638f5503b72cc30008de175b
😎 Deploy Preview	https://deploy-preview-92181--python-cpython-preview.netlify.app/whatsnew/changelog
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[zitterbewegung]

• Fixed word wrap issue
• Removed duplicate news entry.

[zitterbewegung]

Removed trailing whitespace

[zitterbewegung]

I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

[zitterbewegung]

@erlend-aasland can this be reviewed?

[miss-islington]

Thanks @zitterbewegung for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

[erlend-aasland]

Sorry for the delay; thanks Greg for merging. Thanks for the PR, Joshua.