Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92206: Improve scoping of sqlite3 statement step helper #92207

Merged
merged 1 commit into from
May 3, 2022
Merged

gh-92206: Improve scoping of sqlite3 statement step helper #92207

merged 1 commit into from
May 3, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 3, 2022 •
edited
Loading

resolves gh-92206

JelleZijlstra
JelleZijlstra approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we shouldn't backport this.

@JelleZijlstra JelleZijlstra self-assigned this May 3, 2022
@erlend-aasland
Copy link
Contributor Author

I assume we shouldn't backport this.

Yep

@erlend-aasland erlend-aasland mentioned this pull request May 3, 2022
Closed
5 tasks
@erlend-aasland erlend-aasland changed the title gh-92206: Move pysqlite_step() to Modules/_sqlite/cursor.c gh-92206: Improve scoping of sqlite3 statement step helper May 3, 2022
@JelleZijlstra JelleZijlstra merged commit e846fe3 into python:main May 3, 2022
@erlend-aasland erlend-aasland deleted the sqlite-move-step branch May 3, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3: improve scoping of functions in the sqlite3 extension module
3 participants
@erlend-aasland @JelleZijlstra @bedevere-bot