Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-81057: Update globals-to-fix.tsv to follow recent changes #92959

Merged
merged 1 commit into from
May 20, 2022
Merged

gh-81057: Update globals-to-fix.tsv to follow recent changes #92959

merged 1 commit into from
May 20, 2022

Conversation

corona10
Copy link
Member

There were several name changes of static type. I am not sure that this whitelist is still used but should be updated for future work.

@corona10 corona10 marked this pull request as ready for review May 19, 2022 14:28
@kumaraditya303
Copy link
Contributor

Relevant issues:

ericsnowcurrently
ericsnowcurrently reviewed May 20, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Updating this file isn't critical since the tooling would catch it later anyway. However, it doesn't hurt, so thanks!

@corona10 corona10 merged commit 909868d into python:main May 20, 2022
@corona10 corona10 deleted the gh-81057-whitelist branch May 20, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @kumaraditya303 @ericsnowcurrently @bedevere-bot