Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92913: Clarify change to init config module_search_paths[_set] fields #92980

Merged
merged 3 commits into from
May 19, 2022
Merged

gh-92913: Clarify change to init config module_search_paths[_set] fields #92980

merged 3 commits into from
May 19, 2022

Conversation

zooba
Copy link
Member

@zooba zooba commented May 19, 2022 •
edited
Loading

Fixes #92913

@zooba zooba added the needs backport to 3.11 only security fixes label May 19, 2022
@zooba zooba merged commit 403d16f into python:main May 19, 2022
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@zooba zooba deleted the gh-92913 branch May 19, 2022 19:23
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@zooba @miss-islington
pythongh-92913: Clarify changes to PyInitConfig.module_search_paths[_…
79df008 
…set] fields (pythonGH-92980)

(cherry picked from commit 403d16f)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2022
@bedevere-bot
Copy link

GH-92982 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request May 19, 2022
@miss-islington @zooba
gh-92913: Clarify changes to PyInitConfig.module_search_paths[_set] f…
4eb2f40 
…ields (GH-92980)

(cherry picked from commit 403d16f)

Co-authored-by: Steve Dower <steve.dower@python.org>
freakboy3742
freakboy3742 reviewed May 19, 2022
View reviewed changes
Doc/c-api/init_config.rst
/* Specify sys.path explicitly */
/* To calculate the default and then modify, finish initialization and
then use PySys_GetObject("path") to get the list. */
condig.module_search_paths_set = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two typos in this line: condig, and missing a trailing semicolon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was zoned out of my mind with fatigue/allergies when I did this PR, so I'm impressed this was the worst of it (it wasn't the worst of my whole day, unfortunately)

@zooba zooba mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in sys.path construction behaviour of Py_InitializeFromConfig()
4 participants
@zooba @miss-islington @bedevere-bot @freakboy3742