Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92898: Enhance _testcppext test on cast to PyObject* #93111

Merged
merged 2 commits into from
May 26, 2022
Merged

gh-92898: Enhance _testcppext test on cast to PyObject* #93111

merged 2 commits into from
May 26, 2022

Conversation

vstinner
Copy link
Member

  • Add StrongRef class.
  • Rename and reformat functions of the _Py_CAST() implementation.

@vstinner
gh-92898: Enhance _testcppext test on cast to PyObject*
b5cf8b6 
* Add StrongRef class.
* Rename and reformat functions of the _Py_CAST() implementation.
@vstinner
Copy link
Member Author

I'm not sure that having a separated _Py_STATIC_CAST() macro is still needed with the new _Py_CAST() implementation. Maybe _Py_STATIC_CAST() can now be replaced with _Py_CAST().

@vstinner
Copy link
Member Author

I added a NEWS entry for #92951 change, since at least greenlet and scipy were impacted by C++ compiler warnings with Python 3.11 beta1.

@vstinner vstinner mentioned this pull request May 23, 2022
Merged
@vstinner
Copy link
Member Author

cc @serge-sans-paille @corona10 @erlend-aasland @tacaswell

@vstinner vstinner merged commit 20d30ba into python:main May 26, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@vstinner vstinner deleted the cpp_cast branch May 26, 2022 23:12
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2022
@vstinner @miss-islington
pythongh-92898: Enhance _testcppext test on cast to PyObject* (python…
5846beb 
…GH-93111)

* Add StrongRef class.
* Rename and reformat functions of the _Py_CAST() implementation.
(cherry picked from commit 20d30ba)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 26, 2022
@bedevere-bot
Copy link

GH-93275 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request May 26, 2022
@miss-islington @vstinner
gh-92898: Enhance _testcppext test on cast to PyObject* (GH-93111)
9303a5a 
* Add StrongRef class.
* Rename and reformat functions of the _Py_CAST() implementation.
(cherry picked from commit 20d30ba)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @miss-islington @bedevere-bot