Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-83638: Add sqlite3.Connection.autocommit for PEP 249 compliant behaviour #93823

Merged
merged 82 commits into from
Nov 12, 2022
Merged

gh-83638: Add sqlite3.Connection.autocommit for PEP 249 compliant behaviour #93823

merged 82 commits into from
Nov 12, 2022

Commits on Jun 14, 2022

  1. Add sqlite3.Connection.autocommit for PEP 249 compliant behaviour

    @erlend-aasland
    erlend-aasland committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    10d3a65 View commit details
    Browse the repository at this point in the history

  2. Add basic tests

    @erlend-aasland
    erlend-aasland committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    6ca9045 View commit details
    Browse the repository at this point in the history

  3. Add documentation

    @erlend-aasland
    erlend-aasland committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    5772676 View commit details
    Browse the repository at this point in the history

  4. Add NEWS

    @erlend-aasland
    erlend-aasland committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    06609f3 View commit details
    Browse the repository at this point in the history

  5. Add What's New

    @erlend-aasland
    erlend-aasland committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    8b6b866 View commit details
    Browse the repository at this point in the history

  6. Document DEPRECATED_TRANSACTION_CONTROL

    @erlend-aasland
    erlend-aasland committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    a604a57 View commit details
    Browse the repository at this point in the history

  7. Fix setattr behaviour

    @erlend-aasland
    erlend-aasland committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    cbc1041 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Suggest new behaviour starting with Python 3.14

    @erlend-aasland
    erlend-aasland committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    41b898c View commit details
    Browse the repository at this point in the history

  2. Simplify implicit rollback test

    @erlend-aasland
    erlend-aasland committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    b11ebd2 View commit details
    Browse the repository at this point in the history

  3. Address Alex' review

    @erlend-aasland
    erlend-aasland committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    d3009d4 View commit details
    Browse the repository at this point in the history

  4. Reorder if condition to add emphasis to deprecated behaviour

    @erlend-aasland
    erlend-aasland committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    fb98615 View commit details
    Browse the repository at this point in the history

  5. Add context manager tests

    @erlend-aasland
    erlend-aasland committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    5e4626e View commit details
    Browse the repository at this point in the history

  6. Improve 5e4626e

    @erlend-aasland
    erlend-aasland committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    a8e3b9e View commit details
    Browse the repository at this point in the history

  7. Add executescript tests

    @erlend-aasland
    erlend-aasland committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    d46e9be View commit details
    Browse the repository at this point in the history

  8. Improve docs

    @erlend-aasland
    erlend-aasland committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    c2e2f1a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Add missing versionadded

    @erlend-aasland
    erlend-aasland committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    3bf3ee1 View commit details
    Browse the repository at this point in the history

  2. Try to further improve the docs

    @erlend-aasland
    erlend-aasland committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    757f70b View commit details
    Browse the repository at this point in the history

  3. Nano-optimisation

    @erlend-aasland
    erlend-aasland committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    a5ef40c View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Explicit downcast

    @erlend-aasland
    erlend-aasland committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    ae37fbb View commit details
    Browse the repository at this point in the history

  2. Clarify execute*, commit, rollback, and close 

    - execute*(): Explain that DML queries implicitly open transactions if
  autocommit is in compat mode.
- commit/rollback/close: incorporate pythongh-93926 changes
    @erlend-aasland
    erlend-aasland committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    341e0dd View commit details
    Browse the repository at this point in the history

  3. Incorporate pythongh-93890 changes

    @erlend-aasland
    erlend-aasland committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    77651c0 View commit details
    Browse the repository at this point in the history

  4. Improve

    @erlend-aasland
    erlend-aasland committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    0ac782c View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    7743f34 View commit details
    Browse the repository at this point in the history

  2. commit/rollback wordings

    @erlend-aasland
    erlend-aasland committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    6628e30 View commit details
    Browse the repository at this point in the history

  3. Fix merge

    @erlend-aasland
    erlend-aasland committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    060bd3a View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Doc: reword context manager section

    @erlend-aasland
    erlend-aasland committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    c96adbf View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Autocommit is keyword only

    @erlend-aasland
    erlend-aasland committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    a7c7c4c View commit details
    Browse the repository at this point in the history

  2. Isolation level is not yet deprecated (soon it will be though)

    @erlend-aasland
    erlend-aasland committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    f1c5843 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    491426e View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    05879a9 View commit details
    Browse the repository at this point in the history

  2. Use macro as C default

    @erlend-aasland
    erlend-aasland committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    97ad734 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    bf3a857 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    60f7224 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Pass keywords to factory function

    @erlend-aasland
    erlend-aasland committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    7f645ee View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    88fb2b9 View commit details
    Browse the repository at this point in the history

  3. Adjust commit/rollback and remove redundant info

    @erlend-aasland
    erlend-aasland committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    4deed17 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    f3a9e37 View commit details
    Browse the repository at this point in the history

  2. Fix docstring

    @erlend-aasland
    erlend-aasland committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    2981a6b View commit details
    Browse the repository at this point in the history

  3. Revert unneeded doc changes

    @erlend-aasland
    erlend-aasland committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    a5b7864 View commit details
    Browse the repository at this point in the history

  4. Fix autocommit enum

    @erlend-aasland
    erlend-aasland committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    fd6659a View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Sync with main bco. recent doc updates

    @erlend-aasland
    erlend-aasland committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    52e3736 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    6e92073 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    59fbd29 View commit details
    Browse the repository at this point in the history

  2. Add autocommit to connect signature

    @erlend-aasland
    erlend-aasland committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    894fcce View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    fff4307 View commit details
    Browse the repository at this point in the history

  2. Address Alex's second review

    @erlend-aasland
    erlend-aasland committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    4ac0fa0 View commit details
    Browse the repository at this point in the history

  3. Adjust headings

    @erlend-aasland
    erlend-aasland committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    64c6482 View commit details
    Browse the repository at this point in the history

  4. Use versionadded iso. versionchanged

    @erlend-aasland
    erlend-aasland committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    e4947d0 View commit details
    Browse the repository at this point in the history

  5. Remove some no-ops

    @erlend-aasland
    erlend-aasland committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    5981536 View commit details
    Browse the repository at this point in the history

  6. Three adjustments: 

    - Fix incorrect markup
- Update isolation_level description
- Promote commit()/rollback() in PEP 249 compliant mode
    @erlend-aasland
    erlend-aasland committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    527e6a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Address Alex's last round of review

    @erlend-aasland
    erlend-aasland committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    697b65a View commit details
    Browse the repository at this point in the history

  2. Sync with main bco. recent Argument Clinic changes

    @erlend-aasland
    erlend-aasland committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    4299874 View commit details
    Browse the repository at this point in the history

  3. Regen all

    @erlend-aasland
    erlend-aasland committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    76122be View commit details
    Browse the repository at this point in the history

  4. Explicit logic in set_autocommit

    @erlend-aasland
    erlend-aasland committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    6902738 View commit details
    Browse the repository at this point in the history

  5. Tweak naming: connection_txn_stmt => connection_exec_stmt

    @erlend-aasland
    erlend-aasland committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    c37ebb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Merge branch 'main' into sqlite-autocommit

    @erlend-aasland
    erlend-aasland committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    2e9083c View commit details
    Browse the repository at this point in the history

  2. Address review: improve wording for connection close()

    @erlend-aasland
    erlend-aasland committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    b944a90 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Sync with main

    @erlend-aasland
    erlend-aasland committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    bce921f View commit details
    Browse the repository at this point in the history

  2. Fix bad merge

    @erlend-aasland
    erlend-aasland committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    78e04f0 View commit details
    Browse the repository at this point in the history

  3. Remove implicit commit for cx.autocommit = False

    @erlend-aasland
    erlend-aasland committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    bd91e34 View commit details
    Browse the repository at this point in the history

  4. Doc: make the autocommit reference more to the point; expand in the e… 

    …xplanation
    @erlend-aasland
    erlend-aasland committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    9d66daa View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Address most of CAM's review

    @erlend-aasland
    erlend-aasland committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    d4c0583 View commit details
    Browse the repository at this point in the history

  2. Better naming for the constant; don't mention deprecations (yet)

    @erlend-aasland
    erlend-aasland committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    a3aa9aa View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2022

  1. Fix default role

    @erlend-aasland
    erlend-aasland committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    c9b05ff View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Make it explicit that isolation_level is ignored if autocommit is Tru… 

    …e or False
    @erlend-aasland
    erlend-aasland committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    d5e33f1 View commit details
    Browse the repository at this point in the history

  2. Reflow

    @erlend-aasland
    erlend-aasland committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    0cf022a View commit details
    Browse the repository at this point in the history

  3. Address review: COMPAT_TRANSACTIONAL_CONTROL => LEGACY_TRANSACTION_CO… 

    …NTROL
    @erlend-aasland
    erlend-aasland committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    5009372 View commit details
    Browse the repository at this point in the history

  4. Address more of CAM's review

    @erlend-aasland
    erlend-aasland committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    2c9b117 View commit details
    Browse the repository at this point in the history

  5. Try to address the rest of CAM's review

    @erlend-aasland
    erlend-aasland committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    de3bd4e View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. Sync with main

    @erlend-aasland
    erlend-aasland committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    fca9c56 View commit details
    Browse the repository at this point in the history

  2. Address more of CAM's remarks

    @erlend-aasland
    erlend-aasland committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    7de6bf3 View commit details
    Browse the repository at this point in the history

  3. Prevent segfault if implicitly rolling back during interpreter shutdown

    @erlend-aasland
    erlend-aasland committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    e0fa134 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Update Doc/library/sqlite3.rst 

    Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend E. Aasland and CAM-Gerlach authored Nov 7, 2022
    Configuration menu
    Copy the full SHA
    e0bedf6 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Address last batch of CAM's comments

    @erlend-aasland
    erlend-aasland committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e33946a View commit details
    Browse the repository at this point in the history

  2. Last bit

    @erlend-aasland
    erlend-aasland committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    cd15505 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Update Doc/library/sqlite3.rst 

    Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend E. Aasland and CAM-Gerlach authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    4feefa1 View commit details
    Browse the repository at this point in the history

  2. Sync with main

    @erlend-aasland
    erlend-aasland committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    720ac11 View commit details
    Browse the repository at this point in the history

  3. Update Doc/library/sqlite3.rst 

    Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach
    Erlend E. Aasland and CAM-Gerlach authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    f7c2ae4 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Sync with main

    @erlend-aasland
    erlend-aasland committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    88e1420 View commit details
    Browse the repository at this point in the history

  2. Address review: remove unneeded assert in test_autocommit_setget_invalid

    @erlend-aasland
    erlend-aasland committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    7b87830 View commit details
    Browse the repository at this point in the history

  3. Address review: add test for rollback() if autocommit is True

    @erlend-aasland
    erlend-aasland committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    8322683 View commit details
    Browse the repository at this point in the history

  4. Address review: fixup context manager docs

    @erlend-aasland
    erlend-aasland committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    aca1e22 View commit details
    Browse the repository at this point in the history