Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-83499: Fix closing file descriptors in tempfile #93874

Merged
merged 3 commits into from
Jun 26, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 15, 2022

Closes #83499.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 15, 2022
@serhiy-storchaka
Copy link
Member Author

@pitrou, please take a look at this PR.

@serhiy-storchaka serhiy-storchaka merged commit d4792ce into python:main Jun 26, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d4792ce916b94d090b6c7bce8b0f973e840c9e4e 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2022
)

(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-94287 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 26, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 26, 2022
…onGH-93874)

(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka added 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jun 26, 2022
@serhiy-storchaka serhiy-storchaka deleted the tempfile-close-fd2 branch June 26, 2022 08:08
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed 3.11 only security fixes labels Jun 26, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2022
)

(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 26, 2022
@bedevere-bot
Copy link

GH-94289 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Jun 26, 2022
(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jun 26, 2022
(cherry picked from commit d4792ce)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamedTemporaryFile could cause double-close on an fd if _TemporaryFileWrapper throws
3 participants