Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] Add an error message to the ABI-dump file check #94131

Merged
merged 1 commit into from
Jun 22, 2022
Merged

[3.10] Add an error message to the ABI-dump file check #94131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,16 @@ jobs:
./configure --enable-shared
make -j4
- name: Check for changes in the ABI
run: make check-abidump
run: |
make check-abidump
if [ $? -neq 0 ] ; then
echo "Generated ABI file is not up to date."
echo "Please, add the release manager of this branch as a reviewer of this PR."
echo ""
echo "To learn more about this check, please visit: https://devguide.python.org/setup/?highlight=abi#regenerate-the-abi-dump"
echo ""
exit 1
fi

check_generated_files:
name: 'Check if generated files are up to date'
Expand Down