Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-81040: Improve sqlite3.Cursor.rowcount docs #94940

Merged
merged 2 commits into from
Jul 22, 2022
Merged

gh-81040: Improve sqlite3.Cursor.rowcount docs #94940

merged 2 commits into from
Jul 22, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 17, 2022 •
edited
Loading

Resolves gh-81040

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 17, 2022
@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 17, 2022
CAM-Gerlach
CAM-Gerlach reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggested tweaks, otherwise LGTM, thanks

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, CAM!

@erlend-aasland erlend-aasland merged commit f9b3706 into python:main Jul 22, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-doc-rowcount branch July 22, 2022 07:34
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2022
@erlend-aasland @miss-islington
pythongh-81040: Improve sqlite3.Cursor.rowcount docs (pythonGH-94940)
bca4b3d 
(cherry picked from commit f9b3706)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2022
@bedevere-bot
Copy link

GH-95124 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2022
@erlend-aasland @miss-islington
pythongh-81040: Improve sqlite3.Cursor.rowcount docs (pythonGH-94940)
7bcc42a 
(cherry picked from commit f9b3706)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 22, 2022
@bedevere-bot
Copy link

GH-95125 is a backport of this pull request to the 3.10 branch.

@erlend-aasland erlend-aasland mentioned this pull request Jul 22, 2022
Closed
miss-islington added a commit that referenced this pull request Jul 22, 2022
@miss-islington @erlend-aasland
gh-81040: Improve sqlite3.Cursor.rowcount docs (GH-94940)
02f1cac 
(cherry picked from commit f9b3706)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Jul 22, 2022
@miss-islington @erlend-aasland
gh-81040: Improve sqlite3.Cursor.rowcount docs (GH-94940)
12b56e4 
(cherry picked from commit f9b3706)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
@AlexWaygood AlexWaygood removed their request for review July 28, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3 dml statement detection does not account for CTEs
4 participants
@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach