Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95778: Add pre-check for int-to-str conversion #96537

Merged
merged 14 commits into from
Sep 4, 2022
Merged

gh-95778: Add pre-check for int-to-str conversion #96537

merged 14 commits into from
Sep 4, 2022

Commits on Sep 3, 2022

  1. Add pre-check for int-to-str conversion

    @mdickinson
    mdickinson committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    2fbc9ce View commit details
    Browse the repository at this point in the history

  2. Avoid potential undefined behaviour from overflow

    @mdickinson
    mdickinson committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    d16db91 View commit details
    Browse the repository at this point in the history

  3. Reworked, even cruder bound, that avoids potential issues with intege… 

    …r overflow
    @mdickinson
    mdickinson committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    66a07ac View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Rename the error message constants.

    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    6eadbda View commit details
    Browse the repository at this point in the history

  2. Add a DoS prevention success timed regression test.

    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    195686c View commit details
    Browse the repository at this point in the history

  3. Improve the test to check close to the limit.

    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    87bd23d View commit details
    Browse the repository at this point in the history

  4. Use fewer digits in the test to speed it up on slow hosts. 

    A RPi4 takes 10 seconds for the int_to_str test now.
    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    de9ed4d View commit details
    Browse the repository at this point in the history

  5. Misc: Fix a typo in the header comment.

    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    dbd8da9 View commit details
    Browse the repository at this point in the history

  6. Change timers if process_time() returns 0. #wasm

    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    c49a737 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into fix/int-to-str-dos

    @gpshead
    gpshead authored Sep 4, 2022
    Configuration menu
    Copy the full SHA
    35c5ea7 View commit details
    Browse the repository at this point in the history

  8. Update comment to suggest reading the PR for detail

    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    730915d View commit details
    Browse the repository at this point in the history

  9. Minor comment typo fix (restart CI).

    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    56f08c2 View commit details
    Browse the repository at this point in the history

  10. cleanup the test. 

    skip rather than fail if we find unexpectedly high performance.
    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    4dae3e0 View commit details
    Browse the repository at this point in the history

  11. Add Mark's name to the NEWS entry.

    @gpshead
    gpshead committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    adb1784 View commit details
    Browse the repository at this point in the history