gh-65046: Add note about logging from async code. (GH-97602) #97602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vsajip
commented
Sep 27, 2022
•
vsajip
commented
- Issue: asyncio docs should call out that network logging is a no-no #65046
vsajip
changed the title
vsajip
added
needs backport to 3.10
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 28, 2022
(cherry picked from commit 5c110d1) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
|
GH-97608 is a backport of this pull request to the 3.11 branch. |
bedevere-bot
removed
needs backport to 3.11
|
GH-97609 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 28, 2022
(cherry picked from commit 5c110d1) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
vsajip
pushed a commit
that referenced
this pull request
Sep 28, 2022
vsajip
pushed a commit
that referenced
this pull request
Sep 28, 2022
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.