gh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 #97896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhadthedev
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
|
Retriggering the stuck checks. |
|
Please, feel free to ping me when ready. I will run buildbot tests for you. |
|
@sobolevn Pinging since the tests are done. |
sobolevn
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
gvanrossum
approved these changes
Oct 5, 2022
21 tasks
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Oct 6, 2022
* main: (66 commits) pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879) docs(typing): add "see PEP 675" to LiteralString (python#97926) pythongh-97850: Remove all known instances of module_repr() (python#97876) I changed my surname early this year (python#96671) pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768) pythongh-91539: improve performance of get_proxies_environment (python#91566) build(deps): bump actions/stale from 5 to 6 (python#97701) pythonGH-95172 Make the same version `versionadded` oneline (python#95172) pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073) pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774) pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896) pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383) pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759) pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251) pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662) pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644) pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756) pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778) pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826) Add re.VERBOSE flag documentation example (python#97678) ...
arhadthedev
added a commit
to arhadthedev/cpython
that referenced
this pull request
Oct 7, 2022
…art 2 (python#97896)" This reverts commit 09aea94.
gvanrossum
pushed a commit
that referenced
this pull request
Oct 7, 2022
…_streams: port server cases to IsolatedAsyncioTestCase" (#98015) This PR reverts gh-93369 and gh-97896 because they've made asyncio tests unstable. After these PRs were merged, random GitHub action jobs of random commits started to fail unrelated tests and test framework methods. The reverting is necessary because such shrapnel failures are a symptom of some underlying bug that must be found and fixed first. I had a hope that it's a server overload because we already have extremely rare disc access errors. However, one and a half day passed, and the failures continue to emerge both in PRs and commits. Affected issue: gh-93357. First reported in #97940 (comment). * Revert "gh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (#97896)" This reverts commit 09aea94. * Revert "gh-93357: Start porting asyncio server test cases to IsolatedAsyncioTestCase (#93369)" This reverts commit ce8fc18.
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
…ython#97896) This fixes the buildbots.
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
…o.test_streams: port server cases to IsolatedAsyncioTestCase" (python#98015) This PR reverts pythongh-93369 and pythongh-97896 because they've made asyncio tests unstable. After these PRs were merged, random GitHub action jobs of random commits started to fail unrelated tests and test framework methods. The reverting is necessary because such shrapnel failures are a symptom of some underlying bug that must be found and fixed first. I had a hope that it's a server overload because we already have extremely rare disc access errors. However, one and a half day passed, and the failures continue to emerge both in PRs and commits. Affected issue: pythongh-93357. First reported in python#97940 (comment). * Revert "pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)" This reverts commit 09aea94. * Revert "pythongh-93357: Start porting asyncio server test cases to IsolatedAsyncioTestCase (python#93369)" This reverts commit ce8fc18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to gh-93369 to fix broken Ubuntu SSL tests with OpenSSL and Ubuntu SSL tests with OpenSSL (3.0.5) tests.
The break is caused by
async-isation of a few tests inclass StreamTests2(test_utils.TestCase)not designed for this. Since they happen to be grouped in the end of a file, it's easier to group them under an unplannedclass NewStreamTests2(unittest.IsolatedAsyncioTestCase)and make three in-between testsasynctoo rather that partially roll the changes back.Thanks to @kumaraditya303 for noticing the issue.
Closes gh-97894.
test.test_asyncio.utils.TestCasewithunittest.IsolatedAsyncioTestCase#93357