Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98692: Enable treating shebang lines as executables in py.exe launcher #98732

Merged
merged 7 commits into from
Oct 31, 2022
Merged

gh-98692: Enable treating shebang lines as executables in py.exe launcher #98732

merged 7 commits into from
Oct 31, 2022

Conversation

zooba
Copy link
Member

@zooba zooba commented Oct 26, 2022 •
edited by bedevere-bot
Loading

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.11 only security fixes labels Oct 26, 2022
@zooba zooba requested a review from a team as a code owner October 26, 2022 16:47
@zooba
Copy link
Member Author

zooba commented Oct 26, 2022

Still needs tests, but please review

eryksun
eryksun reviewed Oct 26, 2022
View reviewed changes
PC/launcher2.c Outdated Show resolved Hide resolved
eryksun
eryksun reviewed Oct 26, 2022
View reviewed changes
PC/launcher2.c Outdated Show resolved Hide resolved
@zooba zooba merged commit 88297e2 into python:main Oct 31, 2022
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@zooba zooba deleted the gh-98692 branch October 31, 2022 21:05
@bedevere-bot
Copy link

GH-98926 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2022
@zooba @miss-islington
pythongh-98692: Enable treating shebang lines as executables in py.ex…
290c543 
…e launcher (pythonGH-98732)

(cherry picked from commit 88297e2)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 31, 2022
miss-islington added a commit that referenced this pull request Oct 31, 2022
@miss-islington @zooba
gh-98692: Enable treating shebang lines as executables in py.exe laun…
46a3cf4 
…cher (GH-98732)

(cherry picked from commit 88297e2)

Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba zooba mentioned this pull request Nov 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eryksun eryksun eryksun left review comments

Assignees
No one assigned
Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @eryksun