gh-99344, gh-99379, gh-99382: Fix issues in substitution of ParamSpec and TypeVarTuple #99412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Nov 12, 2022
•
serhiy-storchaka
commented
- Fix substitution of TypeVarTuple and ParamSpec together in user generics.
- Fix substitution of ParamSpec followed by TypeVarTuple in generic aliases.
- Check the number of arguments in substitution in user generics containing a TypeVarTuple and one or more TypeVar.
- Issue: TypeVarTuple and ParamSpec don't work together #99344
- Issue: Type substitution in generic aliases does not work if ParamSpec is followed by TypeVarTuple #99379
- Issue: User generic with TypeVarTuple does not check for minimal type of arguments #99382
…ution of ParamSpec and TypeVarTuple * Fix substitution of TypeVarTuple and ParamSpec together in user generics. * Fix substitution of ParamSpec followed by TypeVarTuple in generic aliases. * Check the number of arguments in substitution in user generics containing a TypeVarTuple and one or more TypeVar.
serhiy-storchaka
requested review from
gvanrossum,
Fidget-Spinner,
JelleZijlstra and
AlexWaygood
as code owners
|
I'm not sure I'm the one to review this. Maybe @mrahtz can follow this? |
| self.assertEqual(G3.__args__, ((bytes,),)) | ||
| G4 = X[[]] | ||
| self.assertEqual(G4.__args__, ((),)) | ||
| with self.assertRaises(TypeError): |
There was a problem hiding this comment.
Can you add tests for X[int] and Y[int]? (I guess those should raise TypeError.)
There was a problem hiding this comment.
No, unfortunately it does not raise TypeError. The type check for ParamSpec and TypeVar substitution are too lenient and accept any nonsense.
>>> from typing import *
>>> T = TypeVar('T')
>>> P = ParamSpec('P')
>>> class A(Generic[P, T]): pass
...
>>> A[int, [str]]
__main__.A[int, [<class 'str'>]]
>>> A[1, 2]
__main__.A[1, 2]
More strict type checks can be introduced in a separate issue.
mrahtz
approved these changes
Nov 19, 2022
| for C in Callable, collections.abc.Callable: | ||
| with self.subTest(generic=C): | ||
| A = C[P, Tuple[*Ts]] | ||
| B = A[[int, str], bytes, float] |
There was a problem hiding this comment.
Wow, this is an interesting case. Would it be worth checking C[Tuple[*Ts], P] too?
There was a problem hiding this comment.
C is Callable. Callable[Tuple[*Ts], P] does not make sense. It is an error for collections.abc.Callable, and accepted for typing.Callable (producing a meaningless result), but it is a different issue.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-99866 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2022
…ution of ParamSpec and TypeVarTuple (pythonGH-99412) * Fix substitution of TypeVarTuple and ParamSpec together in user generics. * Fix substitution of ParamSpec followed by TypeVarTuple in generic aliases. * Check the number of arguments in substitution in user generics containing a TypeVarTuple and one or more TypeVar. (cherry picked from commit 8f2fb7d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2022
…ution of ParamSpec and TypeVarTuple (pythonGH-99412) * Fix substitution of TypeVarTuple and ParamSpec together in user generics. * Fix substitution of ParamSpec followed by TypeVarTuple in generic aliases. * Check the number of arguments in substitution in user generics containing a TypeVarTuple and one or more TypeVar. (cherry picked from commit 8f2fb7d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Nov 29, 2022
… and TypeVarTuple (GH-99412) * Fix substitution of TypeVarTuple and ParamSpec together in user generics. * Fix substitution of ParamSpec followed by TypeVarTuple in generic aliases. * Check the number of arguments in substitution in user generics containing a TypeVarTuple and one or more TypeVar. (cherry picked from commit 8f2fb7d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.