Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] GH-95283: Add note about compilers in Mac/README.txt (GH-99506) #99718

Merged
merged 1 commit into from
Nov 23, 2022
Merged

[3.11] GH-95283: Add note about compilers in Mac/README.txt (GH-99506) #99718

merged 1 commit into from
Nov 23, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 23, 2022 •
edited by bedevere-bot
Loading

The build machinery assumes that the compiler that's used
to build on macOS includes an SDK that's at least as new
as the OS version on the build machine. Explicitly mention
this in Mac/README.txt.
(cherry picked from commit 8f024a0)

Co-authored-by: Ronald Oussoren ronaldoussoren@mac.com

@ronaldoussoren @miss-islington
pythonGH-95283: Add note about compilers in Mac/README.txt (pythonGH-…
0b10549 
…99506)

The build machinery assumes that the compiler that's used
to build on macOS includes an SDK that's at least as new
as the OS version on the build machine. Explicitly mention
this in Mac/README.txt.
(cherry picked from commit 8f024a0)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@miss-islington miss-islington requested a review from a team as a code owner November 23, 2022 10:52
This was referenced Nov 23, 2022
Closed
Merged
@bedevere-bot bedevere-bot added skip news awaiting review docs Documentation in the Doc dir labels Nov 23, 2022
ronaldoussoren
ronaldoussoren approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington miss-islington merged commit 59361ec into python:3.11 Nov 23, 2022
@miss-islington miss-islington deleted the backport-8f024a0-3.11 branch November 23, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miss-islington @ronaldoussoren @bedevere-bot