-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-99728: correct typo in datetime format codes #99750
Merged
kumaraditya303
merged 3 commits into
python:main
from
tbwolfe:datetime-documentation-change
Dec 10, 2022
Merged
gh-99728: correct typo in datetime format codes #99750
kumaraditya303
merged 3 commits into
python:main
from
tbwolfe:datetime-documentation-change
Dec 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation referenced '%J', which is not a valid datetime format code. The documentation was changed to reference '%j' instead.
slateny
reviewed
Nov 26, 2022
Changing order of arguments made this information inconsistent with above table. Reverting ordering change.
slateny
reviewed
Nov 27, 2022
In previous commit, one ordering change was overlooked.
slateny
approved these changes
Nov 28, 2022
kumaraditya303
added
needs backport to 3.10
only security fixes
needs backport to 3.11
only security fixes
labels
Dec 10, 2022
kumaraditya303
approved these changes
Dec 10, 2022
Thanks @tbwolfe for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Thanks |
GH-100158 is a backport of this pull request to the 3.11 branch. |
GH-100159 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 10, 2022
…pythonGH-99750) (cherry picked from commit d5f8a2b) Co-authored-by: Brad Wolfe <brad.wolfe@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 10, 2022
…pythonGH-99750) (cherry picked from commit d5f8a2b) Co-authored-by: Brad Wolfe <brad.wolfe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation referenced '%J', which is not a valid datetime format code. The documentation was changed to reference '%j' instead.