-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] bpo-40882: Fix a memory leak in SharedMemory on Windows (GH-20684) #99911
Conversation
Thanks for the backport! It looks like argument clinic changed enough that it needs to be re-run on the changed file. Should be able to do |
Why did you add an extra period in the commit message? Please remove it. I recall that @zooba Can you please make sure that the extra period is not there when merging? |
502a1d7
to
fc30698
Compare
Removed the extra period in the commit message, and updated the argument clinic using |
No, you didn't remove it. It looks like you removed the period in 3.10 instead, which is wrong (please add it back). In the sentence that begins with "In multiprocessing.shared_memory.SharedMemory", you added an extra period at the end. Please remove it. |
…nGH-20684) In multiprocessing.shared_memory.SharedMemory(), the temporary view returned by MapViewOfFile() should be unmapped when it is no longer needed. (cherry picked from commit 85c128e) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
8160622
to
9eadb2c
Compare
Ah, thanks for the clarification. Was looking at the wrong commit. Its fixed now, and all checks pass. |
This is a backport to Python 3.10 for bpo-40882: Fix a memory leak in SharedMemory on Windows (GH-20684)