Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99955: standardize return values of functions in assembler and optimizer. #99956

Merged
merged 6 commits into from
Dec 2, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Dec 2, 2022

The individual commit may be easier to review.

@markshannon markshannon changed the title gh-99955: standardize return values of functions in assemebler and optimizer. gh-99955: standardize return values of functions in assembler and optimizer. Dec 2, 2022
@markshannon
Copy link
Member

Thanks for doing this.
Does this cover everything in compile.c that used the 0/1 style return?

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the functions changed are static, so you can skip the news item.

@iritkatriel
Copy link
Member Author

Thanks for doing this.
Does this cover everything in compile.c that used the 0/1 style return?

It doesn't cover any of the code-gen function, just optimizer and assembler.

code-gen uses 0/1, and the RETURN_IF_FALSE macro, which I think we should either do without or turn into RETURN_IF_ERROR (which would be -1).

@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Dec 2, 2022
@iritkatriel iritkatriel merged commit ab02262 into python:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants