Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in the enum documentation #99960

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Fix typos in the enum documentation #99960

merged 2 commits into from
Dec 4, 2022

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Dec 3, 2022

No description provided.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 3, 2022
@geryogam geryogam marked this pull request as ready for review December 3, 2022 01:43
ethanfurman
ethanfurman requested changes Dec 3, 2022
View reviewed changes
Doc/library/enum.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@geryogam
Copy link
Contributor Author

geryogam commented Dec 4, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@ethanfurman ethanfurman merged commit 2ae894b into python:main Dec 4, 2022
@ethanfurman
Copy link
Member

Many thanks!

@geryogam
Copy link
Contributor Author

geryogam commented Dec 4, 2022

Thanks for the review!

@geryogam geryogam deleted the patch-18 branch December 4, 2022 20:30
@itamaro itamaro mentioned this pull request Dec 6, 2022
Closed
@ethanfurman ethanfurman self-assigned this Dec 6, 2022
@ethanfurman ethanfurman added the needs backport to 3.11 only security fixes label Dec 6, 2022
@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100051 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2022
@geryogam @miss-islington
[Enum] Fix typos in the documentation (pythonGH-99960)
1c96c2c 
(cherry picked from commit 2ae894b)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull request Dec 6, 2022
@miss-islington @geryogam
[Enum] Fix typos in the documentation (GH-99960)
05031ee 
(cherry picked from commit 2ae894b)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geryogam @bedevere-bot @ethanfurman @miss-islington