Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move .PHONY to each section to avoid copy/paste omissions #972

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 21, 2022

Similar to python/cpython#98189, the list of phony targets in the Makefile had got out of sync with the commands: clean-venv, ensure-venv and serve were missing.

I expect it will happen again because it's easy to copy and paste a target and not realise/remember to update the list of .PHONY targets at the top of the file.

Let's do as @zware suggested in python/cpython#98189 (comment) and put each one right next to its target.

We do this at Pillow and at work, it helps a lot.

(See also python/cpython#98266 to update the CPython docs Makefile and python/peps#2841 for PEPs.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants