-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miss-islington as a GitHub App #659
Conversation
Use Installation Access Token instead of Personal Access token. Note that the Personal Access Token is still needed during cherry-picking/backport process, as there is no GitHub API for cherry-picking.
I still need to do some testing. Don't merge yet. |
Codecov Report
@@ Coverage Diff @@
## main #659 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 356 357 +1
Branches 29 29
=========================================
+ Hits 356 357 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tested on my personal repo and personal bot: Original PR: Mariatta/cpython_for_test#2 Backport PR created by app: Mariatta/cpython_for_test#3 |
You can compare with how we did the conversion for bedevere: python/bedevere#569 |
GitHub App settings:
Permissions & events:
Subscribe to events:
|
During deployment, we realized additional things:
After those are sorted out, things seem to work. |
Use Installation Access Token instead of Personal Access token.
Note that the Personal Access Token is still needed during cherry-picking/backport process, as there is no GitHub API for cherry-picking.
Deployment tasks:
GH_APP_ID
,GH_PRIVATE_KEY
(from the newly created GitHub App in the previous step)