Mypy can now understand deleted TypeInfo
#13481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mypy/binder.py
Outdated
| if not isinstance(get_proper_type(type), PartialType): | ||
| return type | ||
| elif isinstance(expr.node, TypeInfo): | ||
| return Instance( |
There was a problem hiding this comment.
I'm not sure this is right... The declared type of a TypeInfo should probably be expr.node.calculate_metaclass_type() or something right?
I don't have the best sense of this code either, so not sure how much of a difference this makes though.
I did notice another issue while reviewing this PR: #13483
There was a problem hiding this comment.
Fair enough, let's use TypeType for this.
(.calculate_metaclass_type always returns None for regular types)
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now correctly handle deleted
TypeInfoCloses #13226
This is a new part of mypy for me, so careful review is required.