Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 1.13 #18000

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Changelog for 1.13 #18000

merged 1 commit into from
Oct 21, 2024

Conversation

hauntsaninja
Copy link
Collaborator

No description provided.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one (optional) comment.

* Significantly speed up file handling error paths (Shantanu, PR [17920](https://github.com/python/mypy/pull/17920))
* Use fast path in modulefinder more often (Shantanu, PR [17950](https://github.com/python/mypy/pull/17950))
* Let mypyc optimise os.path.join (Shantanu, PR [17949](https://github.com/python/mypy/pull/17949))
* Make is_sub_path faster (Shantanu, PR [17962](https://github.com/python/mypy/pull/17962))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: don't mention is_sub_path in the changelog. since it refers to an internal implementation detail.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep the mention... I think all of these changes are basically internal implementation details (it would be worrisome if they were not ;-) )

The specific is_sub_path change is both one of the bigger perf wins and one of the riskier changes in this series (since the behaviour of is_sub_path is different)

Comment on lines +23 to +24
Mypy 1.13 allows use of the `orjson` library for handling the cache instead of the stdlib `json`,
for improved performance. You can ensure the presence of `orjson` using the `faster-cache` extra:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any stats for this? Any downsides? What's the comparison with sqlite?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on your workload and whether incremental or not, Jukka measured 10-15% in #17955 (comment) , I've seen the lower end of that

It composes with sqlite, since mypy's sqlite thing just dumps json into sqlite. I think sqlite cache is mainly a way to workaround filesystem performance. I haven't benchmarked (or really used) the sqlite option. Jukka mentions he'd like to make it the default in the future though: #17955 (comment)

@hauntsaninja hauntsaninja merged commit e106dd7 into python:master Oct 21, 2024
1 check passed
@hauntsaninja hauntsaninja deleted the changelog branch October 21, 2024 20:10
hauntsaninja added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants