Commits on Sep 2, 2018

1. Add a customize_class_mro plugin hook …

   The rationale for this MRO hook is documented on python#4527
   
   This patch completely addresses my need for customizing the MRO of types that use my metaclass, and I believe it is simple & general enough for other plugin authors.
   
   I did `./runtests.py`, and the only failure is in `testCoberturaParser`, which looks completely unrelated to my changes. Log here: https://gist.github.com/snarkmaster/3f78cf04cfacb7abf2a8da9b95298075
   
   PS You will notice in the patch that I deviated from the pattern of "some_hook(fullname) returns a callback, which takes a context". I did this as a suggestion for improvement. At the very least, all of the -> None hooks could be simplified in this fashion (and probably the others, too). I'm happy to put up a patch for that, if there's a process for dealing with a breaking change in the plugin API.
   
   A specific reason I disliked the original pattern is that the provided fullname often does not have enough information for the hook to decide whether it cares, so the hook has to return a callback always. And yet, we spend cycles specifically extracting & passing just the fullname. For this reason, my base class hook is just return base_class_callback.

   

   snarkmaster committed Sep 2, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 98b369b
   • Browse repository at this point

   Copy the full SHA

   98b369b View commit details

   Browse the repository at this point in the history