Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 480: Clarify automated signing solution to remove key sharing #1711

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

mnm678
Copy link
Contributor

@mnm678 mnm678 commented Nov 10, 2020

This pr removes references to key sharing in the automated signing section, and proposes a small modification that allows multiple maintainers to upload a package without sharing keys.

@brettcannon
Copy link
Member

@pfmoore we should probably change the PEP delegate for this PEP.

@pfmoore
Copy link
Member

pfmoore commented Nov 10, 2020

Agreed. As it's a PyPI related PEP, it should probably be @dstufft.

@mnm678
Copy link
Contributor Author

mnm678 commented Nov 10, 2020

@brainwane opened a pr to change the delegate in #1693.

metadata that PyPI then signs. After the initial trust is established,
developers are required to sign distributions that they upload to PyPI using
the public key's corresponding private key. The signed TUF metadata that
at least one public key's corresponding private key. The signed TUF metadata that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reads better with the 's

metadata that PyPI then signs. After the initial trust is established,
developers are required to sign distributions that they upload to PyPI using
the public key's corresponding private key. The signed TUF metadata that
at least one public key's corresponding private key. The signed TUF metadata that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reads better with the 's

@brainwane
Copy link
Contributor

@dstufft could I ask you to please review this? Thanks!

@brainwane
Copy link
Contributor

@dstufft ping to please review this to unblock relevant work I will be getting into soonish. Thank you.

@CAM-Gerlach
Copy link
Member

Hey @brainwane , is this still active? We can review and merge it from a PEP editor perspective, though we're not subject matter experts like @dstufft . Let us know, thanks!

@brainwane
Copy link
Contributor

@CAM-Gerlach Yes, this change is still active; please go ahead and merge it, and we'll move forward on further discussions of PEP 480 in the relevant Discourse thread. Thank you!

This commit adds an additional step to the automated signing solution
to allow multiple developers to upload keys for the same package
if they are maintainers of the package. This removes the need
to share keys between developers.

An alternative would be to allow each project to delegate
to separate developers. However, this solution would require
uploading additional targets metadata which may complicate
data storage on the repository.

Signed-off-by: marinamoore <mnm678@gmail.com>
@AA-Turner AA-Turner force-pushed the pep480-key-sharing branch from a5d5caf to 159c941 Compare April 26, 2022 16:38
@AA-Turner AA-Turner requested a review from a team as a code owner April 26, 2022 16:38
@AA-Turner
Copy link
Member

Rebased to trigger CI.

A

@AA-Turner
Copy link
Member

PR was proposed by a co-author and @brainwane amongst others have approved, so merging now.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants