PEP-654: add BaseExceptionGroup//ExceptionGroup split #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Mar 1, 2021
| execptions and selects between ``ExceptionGroup`` and ``BaseExceptionGroup`` | ||
| makes the choice automatic. In the rest of the document, unless stated | ||
| otherwise, when we refer to ``ExceptionGroup`` we mean either an | ||
| ``ExceptionGroup`` or a ``BaseExceptionGroup``. |
There was a problem hiding this comment.
This last thing is slightly awkward. Maybe we should write "exception group" when either can be used and "ExceptionGroup" when that specific type is meant? (Maybe do this in a separate PR if it affects a lot of locations in the doc, as I anticipate.)
There was a problem hiding this comment.
Agreed, let's fix and merge the two open PRs and then I'll change this in a new one.
gvanrossum
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.