Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 651 rejected by the SC #1864

Merged
merged 1 commit into from
Mar 9, 2021
Merged

PEP 651 rejected by the SC #1864

merged 1 commit into from
Mar 9, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 8, 2021

No description provided.

@vstinner
Copy link
Member Author

vstinner commented Mar 8, 2021

I was confused by https://www.python.org/dev/peps/pep-0651/ status at python.org, so I created this PR to update its status.

cc @pablogsal @willingc @warsaw @brettcannon @Yhg1s @markshannon

Note: I'm no longer part of the SC ;-)

@gvanrossum gvanrossum requested a review from markshannon March 8, 2021 22:07
CAM-Gerlach
CAM-Gerlach reviewed Mar 9, 2021
View reviewed changes
pep-0651.rst Outdated Show resolved Hide resolved
@markshannon
Copy link
Member

I'm not sure about including that rejection notice, as it includes a couple of inaccuracies.
I think @brettcannon's clarification was much better.
Maybe just link to both emails?

@vstinner
Copy link
Member Author

vstinner commented Mar 9, 2021

I'm not sure about including that rejection notice, as it includes a couple of inaccuracies.

I updated my PR to no longer copy the email, and point to the email thread rather than to a single email.

URL: https://mail.python.org/archives/list/python-dev@python.org/thread/75BFSBM5AJWXOF5OSPLMJQSTP3TDOKRP/

@markshannon: Is that better?

@markshannon
Copy link
Member

Yes, thanks Victor.

@markshannon markshannon merged commit c91e284 into python:master Mar 9, 2021
@vstinner vstinner deleted the reject_pep651 branch March 9, 2021 20:12
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @markshannon @CAM-Gerlach @the-knights-who-say-ni