Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 636: add missing @dataclass #1879

Merged
merged 1 commit into from
Mar 23, 2021
Merged

PEP 636: add missing @dataclass #1879

merged 1 commit into from
Mar 23, 2021

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Mar 19, 2021

otherwise, on trying this example

>>> where_is(Point(x=0, y=42))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: Point() takes no arguments

otherwise, on trying this example

>>> where_is(Point(x=0, y=42))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: Point() takes no arguments
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@nim65s

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@nim65s
Copy link
Contributor Author

nim65s commented Mar 19, 2021

dataclass is already imported on l.338, so maybe we don't need the import and only the class decorator, as you prefer :)

@JelleZijlstra
Copy link
Member

cc @dmoisset as the PEP author.

Technically the decorator is not necessary for the example to work, so I can see an argument for not including it. I'll leave it to Daniel's judgment as the author of the document though; happy to merge this PR if he approves.

Copy link
Contributor

@dmoisset dmoisset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice for people who want to copy& paste the example, thanks

@JelleZijlstra
Copy link
Member

Sounds good! @nim65s could you sign the CLA?

@nim65s
Copy link
Contributor Author

nim65s commented Mar 19, 2021

@JelleZijlstra : done, thanks.

@JelleZijlstra
Copy link
Member

Thanks! It should take a few days for it to clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants