-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 636: add missing @dataclass #1879
Conversation
otherwise, on trying this example >>> where_is(Point(x=0, y=42)) Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: Point() takes no arguments
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
cc @dmoisset as the PEP author. Technically the decorator is not necessary for the example to work, so I can see an argument for not including it. I'll leave it to Daniel's judgment as the author of the document though; happy to merge this PR if he approves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice for people who want to copy& paste the example, thanks
Sounds good! @nim65s could you sign the CLA? |
@JelleZijlstra : done, thanks. |
Thanks! It should take a few days for it to clear. |
otherwise, on trying this example