Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CODEOWNERS #1892

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Introduce CODEOWNERS #1892

merged 1 commit into from
Apr 4, 2021

Conversation

brettcannon
Copy link
Member

All active core devs that have either authored or sponsored a PEP are now listed as the "owner" of that PEP file. This will help PEP editors by automatically assigning PRs to the appropriate core devs.

Closes #1804

@Rosuav
Copy link
Contributor

Rosuav commented Mar 26, 2021

Cool! What's the significance of the commented-out ones? Are they ones where you (or your script, since I presume that wasn't made by hand) didn't find any GitHub user names for that PEP?

LGTM. Also, PEP 8001 has a lot of authors :)

@brandtbucher
Copy link
Member

Thanks for taking the time to do this!

If this was generated from a script, maybe that could be committed as well? I'm thinking that doing so would keep it from getting stale, since anyone with a local copy of the voters repo (or something) could refresh it as needed.

Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I agree with Brandt that it would be great to add the script if the file was auto-generated.

@hugovk
Copy link
Member

hugovk commented Mar 27, 2021

Cool! What's the significance of the commented-out ones?

# Any commented-out PEP predates PEP sponsorship or their authors are no longer
# active core developers.

@Rosuav
Copy link
Contributor

Rosuav commented Mar 27, 2021

Which I somehow managed to not read. Heh.

@brettcannon
Copy link
Member Author

It was a team effort between me, VS Code, and a script. 😉 All the script did was list all the PEP file name along with their author names. Replacing the author names was multi-cursor support in VS Code. Looking up the author name was VS Code's GitHub extension and me just knowing. 😄

IOW there's nothing to check in with this to help maintain anything. If this goes in then every new PEP is going to be expected to update CODEOWNERS.

@hugovk
Copy link
Member

hugovk commented Mar 30, 2021

IOW there's nothing to check in with this to help maintain anything. If this goes in then every new PEP is going to be expected to update CODEOWNERS.

After merge, perhaps add this to PEP 1?

@pradyunsg
Copy link
Member

@hugovk that's done already. :)

https://github.com/python/peps/pull/1892/files#diff-357b9fa6af825713b993fac3d7aa06bde4c02902d87d352239d2ded11767205aR698

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going ahead and merging this.

@willingc willingc merged commit e7698a7 into python:master Apr 4, 2021
@brettcannon
Copy link
Member Author

I was actually putting it off until I had enough time to draft the email to python-committers to announce the change. 😄 I'll go email about this now.

@brettcannon brettcannon deleted the codeowners branch April 5, 2021 23:15
@pablogsal
Copy link
Member

Thanks a lot. This a great work!

One small note, I think two surnames may be not handled correctly:

https://github.com/python/peps/blob/master/.github/CODEOWNERS#L476

@JelleZijlstra
Copy link
Member

@pablogsal I fixed this in #1913. I didn't see any similar mistakes elsewhere in the file, including your other PEPs.

@pablogsal
Copy link
Member

@pablogsal I fixed this in #1913. I didn't see any similar mistakes elsewhere in the file, including your other PEPs.

Thanks a lot! !

@willingc
Copy link
Contributor

willingc commented Apr 6, 2021

@brettcannon Sorry about that. Thanks for taking care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CODEOWNERS for PEP authors/delegates?