PEP 646: Add some broader context #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These sections were requested in some feedback we got when talking to NumPy and JAX folks. OK, this does make an already-long PEP even longer, but I do think this context is important - especially for folks who don't have strong intuitions for how parametric typing works in Python.
Thank god for linters
|
@pradeep90 Have I fairly reflected your opinions on this stuff in this section? Any tweaks you want made? |
shoyer
reviewed
Apr 1, 2021
|
@mrahtz please let me know when you're ready for me to merge this. I won't
have time to review it thoroughly myself, but I can merge it when you say
you're ready.
|
alextp
reviewed
Apr 1, 2021
pradeep90
reviewed
Apr 6, 2021
shoyer
approved these changes
Apr 10, 2021
pradeep90
reviewed
Apr 11, 2021
pradeep90
reviewed
Apr 11, 2021
Co-authored-by: Pradeep Kumar <gohanpra@gmail.com>
shoyer
reviewed
Apr 12, 2021
|
@gvanrossum I think this is ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sections were requested in some feedback we got when talking to NumPy and JAX folks. OK, this does make an already-long PEP even longer, but I do think this context is important - especially for folks who don't have strong intuitions for how parametric typing works in Python.
This is just a draft right now, but I'll submit a PR to get some early feedback from Python folks while I also check with external folks whether this makes sense.