Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CODEOWNERS #1925

Merged
merged 5 commits into from
Apr 13, 2021
Merged

Fix CODEOWNERS #1925

merged 5 commits into from
Apr 13, 2021

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 13, 2021

Fixes #1920

This version works, because I opened #1924 against this branch and it correctly requested review from Brett.

This makes three changes:

@brettcannon brettcannon merged commit 69d0e87 into master Apr 13, 2021
@brettcannon brettcannon deleted the fixcodeown branch April 13, 2021 19:14
@brettcannon
Copy link
Member

Thanks!

@pradyunsg
Copy link
Member

Do we want to add a validation action here, given that this file breaks silently?

Originally suggested in #1920 (comment)

@brettcannon
Copy link
Member

Probably, but I'm not sure how since I'm not aware of any official GitHub validation tool.

@pradyunsg
Copy link
Member

https://github.com/mszostok/codeowners-validator seems like the best choice right now.

@brettcannon
Copy link
Member

I'm honestly more worried about people forgetting to add new PEPs then breaking it with future updates. The format is simple enough that people adding themselves should generally work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out why CODEOWNERS is not working
4 participants