PEP 626: Add length parameter to PyLineTable_InitAddressRange #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les that are not sentinel terminated and makes the extent of the line table explicit.
markshannon
changed the title
markshannon
changed the title
|
I agree that this is a better solution. But since this PEP was accepted with the old API shape, could you add a note telling the reader that this detail was updated? Otherwise LGTM. |
markshannon
force-pushed
the
pep-626-add-length-parameter
branch
from
8170a04 to
50fd7c0
Compare
|
Implementing zero-width ranges lead to me to want to change the opaque part of |
|
I've also updated python/cpython#25657 to use the new struct. |
gvanrossum
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows line tables that are not sentinel terminated and makes the extent of the line table explicit.
See https://bugs.python.org/issue42739 and python/cpython#25657