Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 658: Static Distribution Metadata in the Simple Repository API #1955

Merged
merged 3 commits into from
May 12, 2021

Conversation

uranusjr
Copy link
Contributor

Spawned from pypi/warehouse#8254. Missing fields to be filled later after a number is assigned.

@JelleZijlstra
Copy link
Member

You can take PEP 658; #1944 will need to be renumbered anyway.

@pfmoore
Copy link
Member

pfmoore commented May 10, 2021

This looks broadly good to me. I spotted a couple of typos, I'll do a proper review when I have more time.

@uranusjr uranusjr force-pushed the index-metadata branch 2 times, most recently from 6b53596 to 82f7251 Compare May 10, 2021 14:48
@uranusjr
Copy link
Contributor Author

Thanks, I’ve assigned the number and added the newly-created Discourse link to the document. I admit I didn’t re-read the document myself after writing it 😓

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions, reading the rest now

pep-0658.rst Outdated Show resolved Hide resolved
pep-0658.rst Outdated Show resolved Hide resolved
pep-0658.rst Outdated
PEP: 658
Title: Static Distribution Metadata in the Simple Repository API
Author: Tzu-ping Chung <uranusjr@gmail.com>
Sponsor:
Copy link
Member

@pradyunsg pradyunsg May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put @pfmoore here, and in code owners?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure whether Paul or Donald is better to put in which fields TBH

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is package index stuff, @dstufft is PEP-delegate by default. He can get someone else to handle it if he prefers, and I'd be willing to do it if he wants to pass the job on.

I'd rather not be sponsor, TBH. With the new CODEOWNERS workflow, it looks like that means I'd now be responsible for merging any PRs to the PEP and I don't really have the time to handle that right now...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new CODEOWNERS workflow, it looks like that means I'd now be responsible for merging any PRs to the PEP

I'm happy to remain as chief button-pusher to merge uncontroversial PRs :). I think the main point of the CODEOWNERS change is to make it easier for sponsors to stay up to date on changes to their PEPs, but they don't necessarily have to take care of all changes.

Copy link
Member

@pradyunsg pradyunsg May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donald is gonna be the delegate IIUC, based on the SC's standing delegation for Package Index stuff.

Sponsor is... well, whoever ends up sponsoring this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

pep-0658.rst Outdated Show resolved Hide resolved
pep-0658.rst Outdated Show resolved Hide resolved
pep-0658.rst Outdated Show resolved Hide resolved
pep-0658.rst Outdated Show resolved Hide resolved
pep-0658.rst Outdated Show resolved Hide resolved
pep-0658.rst Outdated Show resolved Hide resolved
pep-0658.rst Outdated Show resolved Hide resolved
@uranusjr uranusjr changed the title New PEP to serve metadata on Simple Repository API PEP 658: Static Distribution Metadata in the Simple Repository API May 10, 2021
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good now, thanks! As @pradyunsg mentioned you'll have to add to the CODEOWNERS file and specify a sponsor.

uranusjr added 2 commits May 11, 2021 23:15
Based on feedback, the metadata file of a distribution is now served at
a pre-determined location (with a ".metadata" suffix), instead of
allowing the repository to specify one.

The data-dist-info-metadata attribute's value is re-purposed to store
the metadata file's hash for validation, based on another suggestion.
@uranusjr
Copy link
Contributor Author

The sponsor has been set to @brettcannon (ref) and the PEP delegate @dstufft (as the standing delegate).

I also made some changes to the proposal according to early feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants