Update instructions to use pep-9999.rst #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems the instructions are old (?) in this README and deviates from [PEP-0012](https://www.python.org/dev/peps/pep-0012).
berkerpeksag
approved these changes
May 15, 2021
|
Thank you. |
|
The changed paragraph is confusing (and, I think, incorrect) compared to the instructions in PEP 12. Authors should use 9999 when there isn’t an assigned number, but this paragraph assumes that 999 has been assigned. I think the original text is correct, but perhaps the example shouldn’t be 999 but rather a more “random” number, and perhaps it should explicitly say to use 9999 if there is no assigned number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the instructions are old (?) in this README and deviates from PEP-0012.