Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 515: fix links #1973

Merged
merged 2 commits into from
May 31, 2021
Merged

PEP 515: fix links #1973

merged 2 commits into from
May 31, 2021

Conversation

skirpichev
Copy link
Member

While working on https://bugs.python.org/issue44267 I've noticed some broken links (first commit). The second one fix links with redirects.

BTW, the stdlib implementation doesn't follow PEP. Is it ok?

@brettcannon
Copy link
Member

@skirpichev in regardes to what's in Python not matching the PEP, it would depend on how much it deviates and whether it's backwards-compatible since what's in the language now has been there for quite some time.

@skirpichev skirpichev deleted the fix-pep-515 branch June 1, 2021 02:31
@skirpichev
Copy link
Member Author

it would depend on how much it deviates

Well, the PEP is clear: "The current proposal is to allow one underscore between digits, and after base specifiers in numeric literals."

PEP also explicitly lists constructors in the stdlib, that allow this. Including the Decimal(). Which, however, accepts any number of underscores in any place.

whether it's backwards-compatible

Apparently, no.

If you think there is something to do wrt the PEP text - please reopen the quoted above issue.

@birkenfeld
Copy link
Member

That's definitely a bug in the Decimal implementation. Whether to fix that at this stage I'll leave to the maintainers of Decimal.

@skirpichev
Copy link
Member Author

skirpichev commented Jun 1, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants