-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 662: Editable installs via virtual wheels #1977
Conversation
Would you mind word wrapping this? See https://www.python.org/dev/peps/pep-0012/#general for guidance. |
Uh, ok doing that makes a PITA to make amendments to the PEP because you have to reindent multiple lines manually after every edit. Ideally we should do that just before merging not? |
If you're explicitly asking for the rest of the PEP to be reviewed before reflowing that's fine, but the reflow will need to happen before the PEP can be accepted. |
I don't think every edit needs to trigger a complete reflow. If you need to add a few words to the middle of a paragraph later, you can just have a shorter line in the middle and leave the rest of the paragraph alone. The thing to aim for is that every line stays within the length limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, but I want to double-check that the :pep:
directives actually turn into hyperlinks as I didn't think they did thanks to us not using sphinx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you add me as the sponsor, take the next PEP number (662), and add me to .github/CODEOWNERS
? I will then approve and merge this.
Sure, I'll ask another day or two to do some clarifications that came up on the discussion topic 🙏 thanks! |
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
All done now 👍 thanks! |
You'd wanna retitle the PR. :) |
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor gaborjbernat@gmail.com