Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 662: Editable installs via virtual wheels #1977

Merged
merged 5 commits into from
Jun 11, 2021

Conversation

gaborbernat
Copy link
Contributor

Signed-off-by: Bernát Gábor gaborjbernat@gmail.com

@gaborbernat gaborbernat requested a review from a team as a code owner June 3, 2021 09:58
@brettcannon
Copy link
Member

Would you mind word wrapping this? See https://www.python.org/dev/peps/pep-0012/#general for guidance.

@gaborbernat
Copy link
Contributor Author

Uh, ok doing that makes a PITA to make amendments to the PEP because you have to reindent multiple lines manually after every edit. Ideally we should do that just before merging not?

@brettcannon
Copy link
Member

If you're explicitly asking for the rest of the PEP to be reviewed before reflowing that's fine, but the reflow will need to happen before the PEP can be accepted.

@JelleZijlstra
Copy link
Member

I don't think every edit needs to trigger a complete reflow. If you need to add a few words to the middle of a paragraph later, you can just have a shorter line in the middle and leave the rest of the paragraph alone. The thing to aim for is that every line stays within the length limit.

pep-9999.rst Outdated Show resolved Hide resolved
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but I want to double-check that the :pep: directives actually turn into hyperlinks as I didn't think they did thanks to us not using sphinx.

pep-9999.rst Outdated Show resolved Hide resolved
pep-9999.rst Outdated Show resolved Hide resolved
pep-9999.rst Outdated Show resolved Hide resolved
pep-9999.rst Outdated Show resolved Hide resolved
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add me as the sponsor, take the next PEP number (662), and add me to .github/CODEOWNERS? I will then approve and merge this.

@gaborbernat
Copy link
Contributor Author

Sure, I'll ask another day or two to do some clarifications that came up on the discussion topic 🙏 thanks!

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat
Copy link
Contributor Author

LGTM! Can you add me as the sponsor, take the next PEP number (662), and add me to .github/CODEOWNERS? I will then approve and merge this.

All done now 👍 thanks!

@pradyunsg
Copy link
Member

You'd wanna retitle the PR. :)

@gaborbernat gaborbernat changed the title TBD: Editable installs PEP 662: Editable installs via virtual wheels Jun 11, 2021
pep-0662.rst Outdated Show resolved Hide resolved
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants