Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 657: addr => addrq #2019

Merged
merged 2 commits into from
Jul 2, 2021
Merged

PEP 657: addr => addrq #2019

merged 2 commits into from
Jul 2, 2021

Conversation

isidentical
Copy link
Member

Consistent with the other existing APIs, e.g int PyCode_Addr2Line(PyCodeObject *co, int addrq).

@isidentical isidentical requested a review from pablogsal July 1, 2021 20:03
@isidentical
Copy link
Member Author

CC: @ammaraskar

isidentical
isidentical commented Jul 1, 2021
View reviewed changes
pep-0657.rst Outdated Show resolved Hide resolved
@isidentical
Copy link
Member Author

@pablogsal committed

pablogsal
pablogsal approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@isidentical isidentical merged commit 1344ff8 into master Jul 2, 2021
@isidentical isidentical deleted the pep657-make-addrq branch July 2, 2021 14:29
@isidentical isidentical restored the pep657-make-addrq branch July 2, 2021 14:29
@isidentical isidentical deleted the pep657-make-addrq branch July 2, 2021 14:29
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@ammaraskar ammaraskar ammaraskar approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isidentical @ammaraskar @pablogsal @the-knights-who-say-ni