PEP 667: Update to account for changes to PEP 558 and feedback from Nick. #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in collections.MutableMapping so it is not needed. Add implementation of __contains__.
gvanrossum
approved these changes
Dec 3, 2021
|
I thought PEP 558 was updated in early November, but it turns out I failed to actually merge the PR. That oversight is fixed now: #2124 The comparison section in PEP 667 will need updates to account for those changes (as PEP 558 now offers the same Python level semantics as 667 - anything that suggests otherwise is an editing oversight in the last update). The implementation is lagging a bit as I'm waiting for @markshannon to reply on python/cpython#27525 (review) (his criticism of my "execution frame" naming idea is both valid and equally applicable to the current "interpreter frame" naming, so I'd like to rename that struct to "frame data" before merging it with the PEP 558 implementation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.