PEP 674: Relationship with the HPy project #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simon Cross of HPy gave me +1 on IRC "on the section you linked" :-) |
timfel
reviewed
Jan 18, 2022
| The HPy project | ||
| --------------- | ||
|
|
||
| The hope with the HPy project is indeed to provide a C API that is close |
There was a problem hiding this comment.
Suggested change
| The hope with the HPy project is indeed to provide a C API that is close | |
| The hope with the HPy project is to provide a C API that is close |
timfel
reviewed
Jan 18, 2022
| --------------- | ||
|
|
||
| The hope with the HPy project is indeed to provide a C API that is close | ||
| to the original API to make porting easy and have it perform as close to |
There was a problem hiding this comment.
Suggested change
| to the original API to make porting easy and have it perform as close to | |
| to the original API—to make porting easy—and have it perform as close to |
timfel
reviewed
Jan 18, 2022
| the existing API as possible. At the same time, HPy is sufficently | ||
| removed to be a good "C extension API" (as opposed to a stable subset of | ||
| the CPython implementation API) that does not leak implementation | ||
| details. To ensure this latter property is why the HPy project tries to |
There was a problem hiding this comment.
Suggested change
| details. To ensure this latter property is why the HPy project tries to | |
| details. To ensure this latter property, the HPy project tries to |
timfel
reviewed
Jan 18, 2022
| For example, numpy 1.22 is made of 307,300 lines of C code, and adapting | ||
| numpy to the this PEP only modified 11 lines (use Py_SET_TYPE and | ||
| Py_SET_SIZE) and adding 4 lines (to define Py_SET_TYPE and Py_SET_SIZE | ||
| for Python 3.8 and older). Porting numpy to HPy is expected to require |
There was a problem hiding this comment.
Suggested change
| for Python 3.8 and older). Porting numpy to HPy is expected to require | |
| for Python 3.8 and older). The beginnings of the NumPy port to HPy already required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.