-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 1: Update language on PEP-Delegate field #2256
Conversation
@brettcannon @warsaw This was a PEP change that our earlier Steering Council decided would be helpful. Unfortunately the earlier PR got stale. Let's approve and merge this one 😄 |
eb2520d
to
96c0efb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Three very minor suggestions (tense and commas), feel free to ignore though
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @willingc and @AA-Turner !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the PR was merged before I hit submit on this review, but I can open another PR to refine the wording
the PEP-Delegate for that PEP, and they will then have the | ||
authority to approve (or reject) that PEP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the PEP-Delegate for that PEP, and they will then have the | |
authority to approve (or reject) that PEP. | |
the PEP-Delegate for that PEP, and if approved by the Steering Council, | |
they will then have the authority to approve (or reject) that PEP. |
Not sure if this is the proper wording, but I would be explicit here to clarify that the SC has to approve their offer, it isn't automatic upon offering (as the text here seems to imply).
The term "PEP-Delegate" is used under the Steering | ||
Council governance model. The PEP's designated decision maker, | ||
the "PEP-Delegate" with the Steering Council's support, is | ||
recorded in the "PEP-Delegate" field in the PEP's header. For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "PEP-Delegate" is used under the Steering | |
Council governance model. The PEP's designated decision maker, | |
the "PEP-Delegate" with the Steering Council's support, is | |
recorded in the "PEP-Delegate" field in the PEP's header. For | |
The term "PEP-Delegate" is used under the Steering Council governance model | |
for the PEP's designated decision maker, as accepted by the Steering Council, | |
and recorded in the "PEP-Delegate" field in the PEP's header. For |
I found the wording here a little choppy, redundant and hard to parse, and suggest a bit of a restructuring to improve this.
Council governance model. The PEP's designated decision maker, | ||
the "PEP-Delegate" with the Steering Council's support, is | ||
recorded in the "PEP-Delegate" field in the PEP's header. For | ||
PEPs written prior to the Steering Council's governance model, the field name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEPs written prior to the Steering Council's governance model, the field name | |
PEPs written prior to the Steering Council governance model, the field name |
Nitpick, but the possessive implies that the Steering Council created the governance model, as opposed to itself being the name of the governance model itself
The terms PEP-Delegate and BDFL-Delegate may be used interchangeably in | ||
discussion. PEP-Delegate is the preferred term under the Steering Council | ||
governance model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The terms PEP-Delegate and BDFL-Delegate may be used interchangeably in | |
discussion. PEP-Delegate is the preferred term under the Steering Council | |
governance model. | |
The term "BDFL-Delegate" is a legacy alias for PEP-Delegate, stemming from | |
the time when Python was led by a BDFL, but otherwise has the same meaning. |
This emphasizes that BDFL-Delegate is a legacy alias and explains its origin, while being simpler and more direct and with less choppiness.
|
||
Individuals offering to serve as PEP-Delegate should notify the Steering | ||
Council, PEP authors and PEP sponsor of their intent to self-nominate. | ||
Individuals taking on this responsibility are free to seek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Individuals taking on this responsibility are free to seek | |
Those taking on this responsibility are free to seek |
Avoid repetition
I already merged this PR. I'd rather not revert. Can you create a new one with any follow up changes? |
Yeah sure—I was going to go ahead with another PR; just wanted to wait to see if anyone objected. Thanks! |
This PR is a revision of the closed PR #1445.